linux-kernel - Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46AA5B7B.7040406@goop.org>
Date:	Fri, 27 Jul 2007 13:54:19 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Neil Horman <nhorman@...driver.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	martin.pitt@...ntu.com, wwoods@...hat.com
Subject: Re: [PATCH 2/3] core_pattern: allow passing of arguments to user
 mode helper when core_pattern is a pipe

Neil Horman wrote:
> +	int helper_argc = 0;
>   
> +		helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
>   

Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to change argv_split to take NULL as the argc pointer,
rather than declare a bunch of unused variables.  Interested in throwing
a patch together?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/