linux-kernel - Re: [PATCH] lockd and nfsd endianness annotation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070727013835.GR27237@ftp.linux.org.uk>
Date:	Fri, 27 Jul 2007 02:38:35 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Neil Brown <neilb@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockd and nfsd endianness annotation fixes

On Thu, Jul 26, 2007 at 09:19:22PM -0400, J. Bruce Fields wrote:
 
> Thanks, uh, I probably saw that message too.
> 
> Hm, trying it just now--it catches the svclock.c mistake, but not the
> one in nfsd/nfs4xdr.c--at least not as far as I can tell.

fs/nfsd/nfs4xdr.c:2659:32: warning: incorrect type in argument 2 (different base types)
fs/nfsd/nfs4xdr.c:2659:32:    expected int [signed] nfserr
fs/nfsd/nfs4xdr.c:2659:32:    got restricted unsigned int [usertype] status

is what got triggered.  I.e. call in
        case OP_SECINFO:
                nfsd4_encode_secinfo(resp, op->status, &op->u.secinfo);
                break;
which pointed to the misannotated function...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/