linux-kernel - Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0707281637n5b123e4aib46c4e4b009b0018@mail.gmail.com>
Date:	Sun, 29 Jul 2007 05:07:54 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
Cc:	"Petko Manolov" <petkan@...rs.sourceforge.net>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Greg Kroah-Hartman" <greg@...ah.com>,
	linux-usb-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

Hi,

On 7/29/07, Jesper Juhl <jesper.juhl@...il.com> wrote:
> Hello,
>
> This patch makes sure we don't dereference a NULL pointer in
> drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
> struct net_device *net = pegasus->net; assignment.
> The existing code checks if 'pegasus' is NULL and bails out if
> it is, so we better not touch that pointer until after that check.
> [...]
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index a05fd97..04cba6b 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -768,11 +768,13 @@ done:
>  static void write_bulk_callback(struct urb *urb)
>  {
>         pegasus_t *pegasus = urb->context;
> -       struct net_device *net = pegasus->net;
> +       struct net_device *net;
>
>         if (!pegasus)
>                 return;
>
> +       net = pegasus->net;
> +
>         if (!netif_device_present(net) || !netif_running(net))
>                 return;

Is it really possible that we're called into this function with
urb->context == NULL? If not, I'd suggest let's just get rid of
the check itself, instead.

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/