linux-kernel - Re: [PATCH] add check do_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070728034719.GA24448@joejin-pc.cn.oracle.com>
Date:	Sat, 28 Jul 2007 11:47:19 +0800
From:	Joe Jin <joe.jin@...cle.com>
To:	gurudas pai <gurudas.pai@...cle.com>
Cc:	Joe Jin <joe.jin@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, jens.axboe@...cle.com,
	linux-kernel@...r.kernel.org, wen.gang.wang@...cle.com,
	Badari Pulavarty <pbadari@...ibm.com>,
	Zach Brown <zach.brown@...cle.com>
Subject: Re: [PATCH] add check do_direct_IO() return val

> I tested Andrew's patch and panic was gone but got few ENOTBLK.
> So I tried with Joe's patch , both panic and ENOTBLK are gone now.
> But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
> was not getting called because of break. So I moved dio_cleanup just 
> after if (ret).

Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
at leater, if call it too early, that means will put_page(), maybe cause
other panic.

Thanks,
Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/