linux-kernel - Re: [linux-usb-devel] Edgeport UPS Monitoring Problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <008001c7d1e9$6a8625b0$03c8a8c0@kroptech.com>
Date:	Sun, 29 Jul 2007 10:04:44 -0400
From:	"Adam Kropelin" <akropel1@...hester.rr.com>
To:	"Nick Pasich" <NewsLetters@...kAndBarb.net>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Nick Pasich" <NewsLetters@...kAndBarb.net>,
	<linux-usb-devel@...ts.sourceforge.net>,
	"Greg Kroah-Hartman" <greg@...ah.com>,
	"Al Borchers" <alborchers@...inerpoint.com>,
	<linux-kernel@...r.kernel.org>,
	"Peter Berger" <pberger@...mson.com>
Subject: Re: [linux-usb-devel] Edgeport UPS Monitoring Problems

From: "Nick Pasich" <NewsLetters@...kAndBarb.net>
> Here's the dmesg output ......
>
> [...]
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: LCR - 
> write to send_cmd_write_uart_register register 0x03
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteUartReg - Not writing to MCR Register
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: MCR - 
> write to send_cmd_write_uart_register register 0x0b
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteUartReg - Not writing to MCR Register
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> change_port_settings - baud rate = 9600
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteBaudRate - NOT Setting baud rate for port = 0, baud = 9600

Yup, there's what I expected. Not setting the baud rate and not writing 
status registers is unlikely to produce working results. This 9600 must 
be the default setting being applied.

> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteUartReg - Not writing to MCR Register
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: MCR - 
> write to send_cmd_write_uart_register register 0x0b
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteUartReg - Not writing to MCR Register
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> change_port_settings - baud rate = 2400
> Jul 29 05:20:07 NICK2 kernel: drivers/usb/serial/io_edgeport.c: 
> SendCmdWriteBaudRate - NOT Setting baud rate for port = 0, baud = 2400

Here's apcupsd trying to set 2400 baud.

Please try the attached patch (against 2.6.22.1). This will allow 
writing to the baud rate and MCR/LCR registers on non-EPIC adapters. I 
suspect the previous code was a copy-paste error.

--Adam

Download attachment "usb-serial-edgeport-non-epic-baud-rate-fix.patch" of type "application/octet-stream" (1495 bytes)