linux-kernel - [2.6 patch] sound/synth/util_mem.c: remove pointless check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070729145549.GB16817@stusta.de>
Date:	Sun, 29 Jul 2007 16:55:49 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	perex@...e.cz
Cc:	linux-kernel@...r.kernel.org
Subject: [2.6 patch] sound/synth/util_mem.c: remove pointless check

The Coverity checker spotted that if anyone would call this function 
with "prev == NULL", he would still get an Oops a few lines below.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

---

--- linux-2.6.22-rc6-mm1/sound/synth/util_mem.c.old	2007-07-24 19:37:50.000000000 +0200
+++ linux-2.6.22-rc6-mm1/sound/synth/util_mem.c	2007-07-24 19:38:37.000000000 +0200
@@ -112,15 +112,15 @@ __snd_util_memblk_new(struct snd_util_me
 	struct snd_util_memblk *blk;
 
 	blk = kmalloc(sizeof(struct snd_util_memblk) + hdr->block_extra_size,
 		      GFP_KERNEL);
 	if (blk == NULL)
 		return NULL;
 
-	if (! prev || prev == &hdr->block)
+	if (prev == &hdr->block)
 		blk->offset = 0;
 	else {
 		struct snd_util_memblk *p = get_memblk(prev);
 		blk->offset = p->offset + p->size;
 	}
 	blk->size = units;
 	list_add(&blk->list, prev);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/