linux-kernel - Re: [2.6 patch] drivers/base/power/: make 2 functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200707291837.37244.rjw@sisk.pl>
Date:	Sun, 29 Jul 2007 18:37:36 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	pavel@...e.cz, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] drivers/base/power/: make 2 functions static

On Sunday, 29 July 2007 16:56, Adrian Bunk wrote:
> suspend_device() and resume_device() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 
> ---

Acked-by: Rafael J. Wysocki <rjw@...k.pl>
 
>  drivers/base/power/power.h   |    6 ------
>  drivers/base/power/resume.c  |    2 +-
>  drivers/base/power/suspend.c |    2 +-
>  3 files changed, 2 insertions(+), 8 deletions(-)
> 
> --- linux-2.6.23-rc1-mm1/drivers/base/power/power.h.old	2007-07-26 05:14:12.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/power.h	2007-07-26 05:15:49.000000000 +0200
> @@ -55,12 +55,6 @@
>  
>  extern void dpm_resume(void);
>  extern void dpm_power_up(void);
> -extern int resume_device(struct device *);
> -
> -/*
> - * suspend.c
> - */
> -extern int suspend_device(struct device *, pm_message_t);
>  
>  #else /* CONFIG_PM */
>  
> --- linux-2.6.23-rc1-mm1/drivers/base/power/resume.c.old	2007-07-26 05:14:28.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/resume.c	2007-07-26 05:14:39.000000000 +0200
> @@ -20,7 +20,7 @@
>   *
>   */
>  
> -int resume_device(struct device * dev)
> +static int resume_device(struct device * dev)
>  {
>  	int error = 0;
>  
> --- linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c.old	2007-07-26 05:16:00.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c	2007-07-26 05:16:17.000000000 +0200
> @@ -54,7 +54,7 @@
>   *	@state:	Power state device is entering.
>   */
>  
> -int suspend_device(struct device * dev, pm_message_t state)
> +static int suspend_device(struct device * dev, pm_message_t state)
>  {
>  	int error = 0;
>  
> 
> 
> 

-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/