linux-kernel - Re: [PATCH] fs/partitions/check.c: add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46ADB2CA.3070107@kernel.sg>
Date:	Mon, 30 Jul 2007 17:43:38 +0800
From:	Eugene Teo <eugeneteo@...nel.sg>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes

Hi Cornelia,

Cornelia Huck wrote:
> On Sun, 29 Jul 2007 10:53:39 +0800,
> Eugene Teo <eugeneteo@...nel.sg> wrote:
[...]
>> +	return;
>> +
>> +err_out_del_link:
>> +	sysfs_remove_link(&p->kobj, "subsystem");
> 
> You need a remove uevent if you did an add uevent above.
> 
>> +err_out_del_kobj:
>> +	kobject_del(&p->kobj);
>> +err_out:
>> +	kfree(p);
> 
> Please use kobject_put() instead.

Thanks for your feedback.

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/