lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jul 2007 15:19:46 +0200 (CEST) From: Jiri Kosina <jikos@...os.cz> To: Jesper Juhl <jesper.juhl@...il.com> cc: Jiri Kosina <jkosina@...e.cz>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Michael Haboustak <mike-@...ci.rr.com>, Andreas Gal <gal@....edu>, Vojtech Pavlik <vojtech@...e.cz>, Greg Kroah-Hartman <greg@...ah.com>, linux-input@...ey.karlin.mff.cuni.cz Subject: Re: [PATCH][hid] Fix a NULL pointer dereference when we fail to allocate memory On Sun, 22 Jul 2007, Jesper Juhl wrote: > If, in usb_hid_configure(), we fail to allocate storage for 'usbhid', > "if (!(usbhid = kzalloc(sizeof(struct usbhid_device), GFP_KERNEL)))", > then we'll jump to the 'fail:' label where we have this code: > usb_free_urb(usbhid->urbin); > usb_free_urb(usbhid->urbout); > usb_free_urb(usbhid->urbctrl); > Since we got here because we couldn't allocate storage for 'usbhid', > what we have here is a NULL pointer dereference - ouch... Hi Jesper, thanks a lot for noticing this, I have queued your patch in HID tree. (and sorry for late reply, I was offline on vacation for some time). -- Jiri Kosina - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists