linux-kernel - Re: [PATCH] usbhid: add ASUS LCM to the blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jul 2007 16:11:07 +0200
From:	Chr <chunkeey@....de>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	linux-usb-devel@...ts.sourceforge.net,
	linux-input@...ey.karlin.mff.cuni.cz, Bernd Dau <bernd@...city.de>,
	Adilson Oliveira <adilson@...uxembarcado.com.br>
Subject: Re: [PATCH] usbhid: add ASUS LCM to the blacklist

On Monday, 30. July 2007, Jiri Kosina wrote:
> On Fri, 27 Jul 2007, Christian Lamparter wrote:
> 
> > Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
> > attached to an internal USB bus. Unfortunatly the device reports a wrong
> > DeviceDescriptor and is therefore identified as a HID device...
> 
> Hi Christian,
> 
> I have slightly modified your patch (let's keep the hid_blacklist[] 
> properly sorted) and applied it into my tree.

Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk type. "
But is there a Order for the bitfields? e.g

shouldn't: hid-quriks.c (line 439, 440)

{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI, 
HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE } 

be:
{..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }


Anyway, thanks for merging! 
	Chr.
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/