linux-kernel - Re: [PATCH] Framebuffer: Consolidated cleanup of pvr2fb.c for Sega Dreamcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070730194854.GA29181@linux-sh.org>
Date:	Tue, 31 Jul 2007 04:48:54 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Adrian McMenamin <lkmladrian@...il.com>
Cc:	"Antonino A. Daplas" <adaplas@...il.com>,
	linux-kernel@...r.kernel.org,
	Ondrej Zajicek <santiago@...reenet.org>
Subject: Re: [PATCH] Framebuffer: Consolidated cleanup of pvr2fb.c for Sega Dreamcast

On Sun, Jul 29, 2007 at 01:39:51AM +0100, Adrian McMenamin wrote:
> This patch consolidates your earlier patch, some cleanup of the
> documentation and, crucially, some better handling of the pvr2
> registers based on more up to date information.
> 
> Testing shows that it seems to work pretty well at 16bpp, 24bpp and
> 32bpp - including proper rendering of the boot logo at all levels
> (previously this was a bit broken even at 16bpp) and giving white
> against black text. Really detailed testing (eg with X11) requires
> support for the maple bus - which isn't (currently - next project
> assuming this is okay) available, but I have no reason to think this
> is broken.
> 
> Incidentally, substituing DIRECTCOLOR for TRUECOLOR appears to break the driver.
> 
> Signed-off by: Adrian McMenamin <adrian@...en.demon.co.uk>


This looks fine to me in any event. I can either wrap this up in my tree
or Tony can include it with his next set of updates if he has any other
concerns. Thanks, Adrian.

Acked-by: Paul Mundt <lethal@...ux-sh.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/