linux-kernel - [PATCH] i386: flush_cpumask doesn't need "or"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2007 15:59:42 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linux Kernel list <linux-kernel@...r.kernel.org>
Cc:	Linus Torvalds <torvalds@...l.org>, Andi Kleen <ak@...e.de>
Subject: [PATCH] i386: flush_cpumask doesn't need "or"

Did I miss something or do we needlessly do an "or" to flush_cpumask
while we could just assign it ? We never exit that function with the
mask not empty and we have a spinlock...

Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
---

Index: linux-work/arch/i386/kernel/smp.c
===================================================================
--- linux-work.orig/arch/i386/kernel/smp.c	2007-07-31 15:54:55.000000000 +1000
+++ linux-work/arch/i386/kernel/smp.c	2007-07-31 15:56:13.000000000 +1000
@@ -375,7 +375,8 @@ void native_flush_tlb_others(const cpuma
 	
 	flush_mm = mm;
 	flush_va = va;
-	cpus_or(flush_cpumask, cpumask, flush_cpumask);
+	flush_cpumask = cpumask;
+
 	/*
 	 * We have to send the IPI only to
 	 * CPUs affected.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/