linux-kernel - Re: [PATCH respin, was PATCH for review] During VM oom condition, kill all threads in process group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070731093132.GA5778@elf.ucw.cz>
Date:	Tue, 31 Jul 2007 11:31:32 +0200
From:	Pavel Machek <pavel@....cz>
To:	Will Schmidt <will_schmidt@...t.ibm.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>, Andi Kleen <ak@...e.de>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH respin, was PATCH for review] During VM oom condition, kill all threads in process group

Hi!

> 
> During VM oom condition, kill all threads in process group.
> 
> We have had complaints where a threaded application is left in a bad
> state after one of it's threads is killed when we hit a VM: out_of_memory
> condition.
> Killing just one of the process threads can leave the application in a
> bad state, whereas killing the entire process group would allow for
> the application to restart, or be otherwise handled, and makes it very
> obvious that something has gone wrong.
> 
> This change allows the entire process group to be taken down, rather
> than just the one thread.
> 
> Signed-off-by: Will Schmidt <will_schmidt@...t.ibm.com>

> diff --git a/arch/sparc64/mm/fault.c b/arch/sparc64/mm/fault.c
> index 17123e9..13fdfa3 100644
> --- a/arch/sparc64/mm/fault.c
> +++ b/arch/sparc64/mm/fault.c
> @@ -466,7 +466,7 @@ out_of_memory:
>  	up_read(&mm->mmap_sem);
>  	printk("VM: killing process %s\n", current->comm);
>  	if (!(regs->tstate & TSTATE_PRIV))
> -		do_exit(SIGKILL);
> +		do_group_exit(SIGKILL);
>  	goto handle_kernel_fault;
>  
>  intr_or_no_mm:

is the printk still accurate (does it kill more than one process now)?
Why does it print when it will not really kill the process?

I see similar code across all the archs... would it make sense to
create common helper... or is the helper too trivial?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/