linux-kernel - Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m17iogrgjw.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 31 Jul 2007 04:52:35 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Huang, Ying" <ying.huang@...el.com>
Cc:	Pavel Machek <pavel@....cz>, nigel@...el.suspend2.net,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jeremy Maitin-Shepard <jbms@....edu>,
	Alan Stern <stern@...land.harvard.edu>,
	Andrew Morton <akpm@...ux-foundation.org>, david@...g.hm,
	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	Kexec Mailing List <kexec@...ts.infradead.org>
Subject: Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

"Huang, Ying" <ying.huang@...el.com> writes:

> On Tue, 2007-07-31 at 11:10 +0200, Pavel Machek wrote:
>> > Index: kexec-tools-1.101/kexec/arch/i386/crashdump-x86.c
>> > ===================================================================
>> > --- kexec-tools-1.101.orig/kexec/arch/i386/crashdump-x86.c 2007-07-08
> 23:00:25.000000000 +0800
>> > +++ kexec-tools-1.101/kexec/arch/i386/crashdump-x86.c 2007-07-14
> 17:06:45.000000000 +0800
>> > @@ -428,6 +428,29 @@
>> >  	return 0;
>> >  }
>> >  
>> > +/* Adds the kexec_backup= command line parameter to command line. */
>> > +static int cmdline_add_backup(char *cmdline, unsigned long addr)
>> > +{
>> > +	int cmdlen, len, align = 1024;
>> > +	char str[30], *ptr;
>> > +
>> > +	/* Passing in kexec_backup=xxxK format. Saves space required
>> > +	 * in cmdline. Ensure 1K alignment*/
>> > +	if (addr%align)
>> > +		return -1;
>> > +	addr = addr/align;
>> > +	ptr = str;
>> > +	strcpy(str, " kexec_backup=");
>> > +	ptr += strlen(str);
>> > +	ultoa(addr, ptr);
>> > +	strcat(str, "K");
>> > +	len = strlen(str);
>> > +	cmdlen = strlen(cmdline) + len;
>> > +	if (cmdlen > (COMMAND_LINE_SIZE - 1))
>> > +		die("Command line overflow\n");
>> > +	strcat(cmdline, str);
>> > +	return 0;
>> > +}
>> 
>> This part did not apply for me -- it seems crashdump related and I did
>> not have that applied. Is it critical?
>
> This is needed for kexec_jump to work properly. Which version of
> kexec-tools do you use? This patch is against 1.101. The kdump patch
> must be applied before this patch is applied.

Please work against the kexec-tools-testing tree, if you can.
All of the outstanding patches should be there.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/