linux-kernel - Re: [PATCH 4/7] sysfs: simplify sysfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070731145935.3398cfba@gondolin.boeblingen.de.ibm.com>
Date:	Tue, 31 Jul 2007 14:59:35 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	ebiederm@...ssion.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, satyam@...radead.org,
	stern@...land.harvard.edu
Subject: Re: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()

On Tue, 31 Jul 2007 19:15:08 +0900,
Tejun Heo <htejun@...il.com> wrote:

> With the shadow directories gone, sysfs_remove_dir() can be simplified.
> 
> * parent doesn't need to be grabbed separately.  Just access
>   old_dentry->d_parent.
> 
> * parent sd can never change.  Remove code to move under the new
>   parent.
> 
> * Massage comments a bit.
> 
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
>  fs/sysfs/dir.c |   26 ++++----------------------
>  1 files changed, 4 insertions(+), 22 deletions(-)
> 
It's not sysfs_remove_dir(), but sysfs_rename_dir() :) Otherwise this
looks good.

Acked-by: Cornelia Huck <cornelia.huck@...ibm.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/