linux-kernel - Re: [PATCH] fs/partitions/check.c: add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070731130828.GA6900@localhost.localdomain>
Date:	Tue, 31 Jul 2007 21:08:28 +0800
From:	WANG Cong <xiyou.wangcong@...il.com>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Eugene Teo <eugeneteo@...nel.sg>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 4)

On Tue, Jul 31, 2007 at 02:19:53PM +0200, Cornelia Huck wrote:
>On Tue, 31 Jul 2007 19:50:16 +0800,
>WANG Cong <xiyou.wangcong@...il.com> wrote:
>
>> On Mon, Jul 30, 2007 at 07:38:47PM +0800, Eugene Teo wrote:
>> >This patch fixes these warnings:
>> >
>> >fs/partitions/check.c: In function 'add_partition':
>> >fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
>> >	declared with attribute warn_unused_result
>> >fs/partitions/check.c:394: warning: ignoring return value of
>> >	'sysfs_create_link', declared with attribute warn_unused_result
>> >fs/partitions/check.c:401: warning: ignoring return value of
>> >	'sysfs_create_file', declared with attribute warn_unused_result
>> >
>> >Got it right this time. Thanks Cornelia for help.
>> >
>> 
>> <snip>
>> 
>> This was already done some months ago, see this:
>> http://marc.info/?l=linux-mm-commits&m=117624330000536&w=2
>> 
>> I don't know why this work is duplicated.
>
>Ha, that may explain my feeling of deja vu...
>
>IIRC, Andrew dropped the patch from -mm due to clashes with other
>patches. Did you try to re-submit it?

I see. I knew there was another patch against these code.
I thought Andrew's tools can deal with this, but it seems the fact is not.
Managing patches is really a hard work.

And this patch looks OK for me, too. Thanks!

-- 
To do great work, you have to have a pure mind. You can think only about the
mathematics. Everything else is human weakness. Accepting prizes is showing
weakness.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/