linux-kernel - Re: [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707311606.21414.borntraeger@de.ibm.com>
Date:	Tue, 31 Jul 2007 16:06:21 +0200
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	jack@...keye.stone.uk.eu.org
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	Matthew Wilcox <matthew@...l.cx>
Subject: Re: [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers.

Am Dienstag, 31. Juli 2007 schrieb jack@...keye.stone.uk.eu.org:
> -	a = (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + 8, 
GFP_KERNEL);
> +	a = kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL);

NAK.
Same as in some other patches.
"void *" -> "ulong" is not auto casted and will give you a "warning: 
assignment makes integer from pointer without a cast".

Christian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/