linux-kernel - Re: [ck] Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070731140911.GA22076@elte.hu>
Date:	Tue, 31 Jul 2007 16:09:11 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Miguel Figueiredo <elmig@...ianpt.org>
Cc:	ck@....kolivas.org, Matthew Hawkins <darthmdh@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kasper Sandberg <lkml@...anurb.dk>
Subject: Re: [ck] Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)


* Miguel Figueiredo <elmig@...ianpt.org> wrote:

> CFS does not requeue_task() on SCHED_YIELD (used by graphic drivers) 
> as until 2.6.22 and -ck. [...]

as i pointed it out to you it does, the function's name changed:

 /*
  * sched_yield() support is very simple - we dequeue and enqueue
  */
 static void yield_task_fair(struct rq *rq, struct task_struct *p)
 {
         struct cfs_rq *cfs_rq = task_cfs_rq(p);
         u64 now = __rq_clock(rq);

         /*
          * Dequeue and enqueue the task to update its
          * position within the tree:
          */
         dequeue_entity(cfs_rq, &p->se, 0, now);
         enqueue_entity(cfs_rq, &p->se, 0, now);
 }

plus others have tried the SD NOP-yield hack-patch and while it slightly 
improved the SD numbers it did not change the "CFS is smoother" 
experience.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/