linux-kernel - Re: [PATCH] libata: Correct IORDY handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070731164511.4d2f81ee@the-village.bc.nu>
Date:	Tue, 31 Jul 2007 16:45:11 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	akpm@...l.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata: Correct IORDY handling

> 
> > +			dev->pio_mode <= XFER_PIO_2)
> 
>     Overindented line (to my taste :-). And do we really need to check this?
> 

Yes - if it refuses SET_XFER_MODE we really don't want to run any mode
above PIO2. No hardware *should* do this but then this is IDE...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/