linux-kernel - Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jeir80y27m.fsf@sykes.suse.de>
Date:	Tue, 31 Jul 2007 18:20:29 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Greg KH <gregkh@...e.de>
Cc:	WANG Cong <xiyou.wangcong@...il.com>,
	Satyam Sharma <satyam@...radead.org>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	jack@...keye.stone.uk.eu.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

Greg KH <gregkh@...e.de> writes:

> On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote:
>> However, I think using resource_size_t is a bit better than unsigned long,
>> so that we don't need to check the defination of it.
>> 
>> - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL);
>> + res->start = (resource_size_t)kmalloc(*size, GFP_KERNEL);
>> 
>> Is this change OK?
>
> Yes, that is the proper cast to have here.

It will generate a warning when resoure_size_t is 64bit on a 32bit arch.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/