linux-kernel - Re: [PATCH 28] drivers/net/wan/hdlc_fr.c: kmalloc + memset conversion to kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m34pjkqrsm.fsf@maximus.localdomain>
Date:	Tue, 31 Jul 2007 21:47:21 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 28] drivers/net/wan/hdlc_fr.c: kmalloc + memset conversion to kzalloc

Mariusz Kozlowski <m.kozlowski@...land.pl> writes:

> +++ linux-2.6.23-rc1-mm1-b/drivers/net/wan/hdlc_fr.c	2007-07-30 00:25:40.000000000 +0200
> @@ -212,14 +212,13 @@ static pvc_device* add_pvc(struct net_de
>  		pvc_p = &(*pvc_p)->next;
>  	}
>
> -	pvc = kmalloc(sizeof(pvc_device), GFP_ATOMIC);
> +	pvc = kzalloc(sizeof(pvc_device), GFP_ATOMIC);
>  #ifdef DEBUG_PVC
>  	printk(KERN_DEBUG "add_pvc: allocated pvc %p, frad %p\n", pvc, dev);
>  #endif
>  	if (!pvc)
>  		return NULL;
>
> -	memset(pvc, 0, sizeof(pvc_device));

Looks good, thanks.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/