[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1185923052.31134.24.camel@dyn9047017100.beaverton.ibm.com>
Date: Tue, 31 Jul 2007 16:04:12 -0700
From: Badari Pulavarty <pbadari@...ibm.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Joe Jin <joe.jin@...cle.com>, Zach Brown <zach.brown@...cle.com>,
gurudas pai <gurudas.pai@...cle.com>,
torvalds@...ux-foundation.org, jens.axboe@...cle.com,
lkml <linux-kernel@...r.kernel.org>, wen.gang.wang@...cle.com
Subject: Re: [PATCH] add check do_direct_IO() return val
On Tue, 2007-07-31 at 15:34 -0700, Andrew Morton wrote:
> On Tue, 31 Jul 2007 15:25:11 -0700
> Badari Pulavarty <pbadari@...ibm.com> wrote:
>
> > + dio->map_bh.b_state = 0;
>
> ho hum, thanks.
>
> We zero out so many fields in there now that a kzalloc() might yield
> a net gain. 0.000001% in an unnamed benchmark!
Yep. I think its worth doing a kzalloc(). I wanted to understand the
*actual* problem to make sure we are addressing it, rather than
kzalloc() made it disappear.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists