[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46B08695.6030102@ru.mvista.com>
Date: Wed, 01 Aug 2007 17:11:49 +0400
From: Sergei Shtylyov <sshtylyov@...mvista.com>
To: Segher Boessenkool <segher@...nel.crashing.org>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
Vitaly Bordug <vitb@...nel.crashing.org>,
linux-ide@...r.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver
for CF interface
Hello.
Segher Boessenkool wrote:
>>>> + ide@...00000 {
>>>> + compatible = "mmio-ide";
>>>> + device_type = "ide";
>>> Why not "ata"?
> The hardware is called (E)IDE, the protocol is called ATA.
Sorry for not denouncing this earlier. :-)
ATA is the name of ANSI standard describing IDE.
> Or that's what I was told --
Re-check your sources. ;-)
> I think there's some historic revisionism involved, too.
IDE was probably an initial name of the infamous disk hardware/protocol
later standardized as ATA, EIDE (being more of a trademark) more or less
equals to ATA-2.
>> Also, what mmio-ide in the compat properly means in the context of
>> ide_platform which is able to handle both port and memory mapped IDE.
>> I think
>> we must get rid with this crap, and since this IDE register mapping is
>> pretty
>> much board specific, call it something like "mpc8349emitx-ide" instead.
> "mmio-ide" simply is not specific enough. The device_type
Yes.
> should go, too.
> If this IDE interface is board-specific, thee "compatible"
It's "thy", not "thee". ;-)
> property should include the board vendor name and board
> name. Oh, that's what "emitx" tries to do -- it could be
> a bit clearer perhaps ;-)
Yeah, I forgot about the vondor's "fsl," prefix.
> Segher
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists