| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070801132551.5A8132281F@mailserver9.hushmail.com> Date: Wed, 01 Aug 2007 09:25:51 -0400 From: "Scott Thompson" <postfail@...hmail.com> To: <tiwai@...e.de> Cc: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-sound@...r.kernel.org> Subject: Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing On Wed, 01 Aug 2007 06:38:16 -0400 Takashi Iwai <tiwai@...e.de> wrote: >This would be rater a lacking check of returned errors. > >The other changes look incorrect. All these drivers use >card->private_free callback to release the resources even for the >error exit. Thus, you don't need iounmap in each place. > > >thanks, > >Takashi Missed the callback on the audit, will repost this patch (sound/pci) with just the unchecked returns... --------------------------------------- Scott Thompson / postfail@...hmail.com --------------------------------------- -- Click for free information on attaining an equity line of credit. http://tagline.hushmail.com/fc/Ioyw6h4d9K1rpVNolPplpaj6Tmr87LwpU4yqszBO6uxXkrRlUIHweI/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists