linux-kernel - Re: [PATCH] FRV: Make BSG declarations dependent on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185976630.3468.73.camel@localhost.localdomain>
Date:	Wed, 01 Aug 2007 08:57:09 -0500
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...l.org, jens.axboe@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: Make BSG declarations dependent on CONFIG_BLOCK

On Wed, 2007-08-01 at 10:13 +0100, David Howells wrote:
> From: David Howells <dhowells@...hat.com>
> 
> Make BSG function declarations dependent on CONFIG_BLOCK as they are not
> compilable if the block layer is compiled out.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  include/linux/bsg.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/bsg.h b/include/linux/bsg.h
> index 102dc09..e917c41 100644
> --- a/include/linux/bsg.h
> +++ b/include/linux/bsg.h
> @@ -47,6 +47,7 @@ struct sg_io_v4 {
>  };
>  
>  #ifdef __KERNEL__
> +#ifdef CONFIG_BLOCK
>  
>  #if defined(CONFIG_BLK_DEV_BSG)
>  struct bsg_class_device {
> @@ -68,6 +69,7 @@ static inline void bsg_unregister_queue(struct request_queue *rq)
>  }
>  #endif
>  
> +#endif /* CONFIG_BLOCK */
>  #endif /* __KERNEL__ */

Are you sure you're testing with git head?  CONFIG_BLK_DEV_BSG cannot be
set unless CONFIG_BLOCK is (which was a bug in previous releases now
fixed in git head ... unless the fix has gone wrong?).

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/