linux-kernel - [PATCH -mm] Fix defined but not used warning in drivers/kvm/vmx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B0974E.3030703@googlemail.com>
Date:	Wed, 01 Aug 2007 16:23:10 +0200
From:	Gabriel C <nix.or.die@...glemail.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Avi Kivity <avi@...ranet.com>,
	Yaniv Kamay <yaniv@...ranet.com>
Subject: [PATCH -mm] Fix defined but not used warning in drivers/kvm/vmx.c

Hi,

move_msr_up() is used only on X86_64 and generates a warning on !X86_64

...

drivers/kvm/vmx.c:548: warning: 'move_msr_up' defined but not used

...

Signed-off-by: Gabriel Craciunescu <nix.or.die@...glemail.com>

---

PS: Btw Avi why do you think I'm mysterious ?:)
...

git-kvm.patch:    Noted by the mysterious Gabriel C.

...

--- linux-2.6.23-rc1-mm/drivers/kvm/vmx.c.orig	2007-08-01 15:56:41.000000000 +0200
+++ linux-2.6.23-rc1-mm/drivers/kvm/vmx.c	2007-08-01 15:58:24.000000000 +0200
@@ -544,6 +544,7 @@ static void vmx_inject_gp(struct kvm_vcp
 /*
  * Swap MSR entry in host/guest MSR entry array.
  */
+#ifdef CONFIG_X86_64
 static void move_msr_up(struct vcpu_vmx *vmx, int from, int to)
 {
 	struct kvm_msr_entry tmp;
@@ -555,6 +556,7 @@ static void move_msr_up(struct vcpu_vmx 
 	vmx->host_msrs[to] = vmx->host_msrs[from];
 	vmx->host_msrs[from] = tmp;
 }
+#endif
 
 /*
  * Set up the vmcs to automatically save and restore system
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/