linux-kernel - Re: [PATCH 60] drivers/net/wireless/prism54/oid_mgt.c: kmalloc + memset conversion to kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2007 21:12:49 -0400
From:	"Luis R. Rodriguez" <mcgrof@...il.com>
To:	"Mariusz Kozlowski" <m.kozlowski@...land.pl>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 60] drivers/net/wireless/prism54/oid_mgt.c: kmalloc + memset conversion to kzalloc

On 7/31/07, Mariusz Kozlowski <m.kozlowski@...land.pl> wrote:
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

Acked-by: Luis R. Rodriguez <mcgrof@...il.com>

>  drivers/net/wireless/prism54/oid_mgt.c | 25377 -> 25297 (-80 bytes)
>  drivers/net/wireless/prism54/oid_mgt.o | 128460 -> 128284 (-176 bytes)
>
>  drivers/net/wireless/prism54/oid_mgt.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- linux-2.6.23-rc1-mm1-a/drivers/net/wireless/prism54/oid_mgt.c       2007-07-26 13:07:43.000000000 +0200
> +++ linux-2.6.23-rc1-mm1-b/drivers/net/wireless/prism54/oid_mgt.c       2007-07-30 00:27:44.000000000 +0200
> @@ -244,13 +244,11 @@ mgt_init(islpci_private *priv)
>         /* Alloc the cache */
>         for (i = 0; i < OID_NUM_LAST; i++) {
>                 if (isl_oid[i].flags & OID_FLAG_CACHED) {
> -                       priv->mib[i] = kmalloc(isl_oid[i].size *
> +                       priv->mib[i] = kzalloc(isl_oid[i].size *
>                                                (isl_oid[i].range + 1),
>                                                GFP_KERNEL);
>                         if (!priv->mib[i])
>                                 return -ENOMEM;
> -                       memset(priv->mib[i], 0,
> -                              isl_oid[i].size * (isl_oid[i].range + 1));
>                 } else
>                         priv->mib[i] = NULL;
>         }
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/