[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0708011559340.19454@blonde.wat.veritas.com>
Date: Wed, 1 Aug 2007 16:13:46 +0100 (BST)
From: Hugh Dickins <hugh@...itas.com>
To: Jan Blunck <jblunck@...e.de>
cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Bharata B Rao <bharata@...ux.vnet.ibm.com>
Subject: Re: [RFC 11/26] tmpfs white-out support
On Mon, 30 Jul 2007, Jan Blunck wrote:
> Introduce white-out support to tmpfs.
>
> Signed-off-by: Jan Blunck <jblunck@...e.de>
> ---
> include/linux/shmem_fs.h | 1
> mm/shmem.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
I see there's debate about whether this (and its fellows) give the
right semantic to whiteouts; and I've not begun to think about that.
But as a patch to tmpfs for what you're trying to do, it looks just
about fine. I say "just about" because the reference counting looks
right, but I wouldn't dare say that it _is_ right without testing.
And I'd probably want to add a minor adjustment, so that a mount with
nr_inodes=1000 could still support exactly 1000 inodes, despite your
allocating one for the whiteout (usually never used) at mount time.
But that can follow along later, no problem.
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists