linux-kernel - Re: [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Aug 2007 00:17:50 +0900
From:	Tejun Heo <htejun@...il.com>
To:	NeilBrown <neilb@...e.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end_io.

NeilBrown wrote:
> As bi_end_io is only called once when the reqeust is compelte,
> the 'size' argument is now redundant.  Remove it.
> 
> Now there is no need for bio_endio to subtract the size completed
> from bi_size.  So don't do that either.
> 
> While we are at it, change bi_end_io to return void.
> 
> Signed-off-by: Neil Brown <neilb@...e.de>
> 
> @@ -538,14 +538,10 @@ static int flush_dry_bio_endio(struct bi
>  
>  	/* Reset bio */
>  	set_bit(BIO_UPTODATE, &bio->bi_flags);
> -	bio->bi_size = bytes;
> -	bio->bi_sector -= (bytes >> 9);
> -
> -	return 0;
>  }

Please adjust comment together.  Just keeping /* Reset bio */ and
killing the comment above it should be enough.  Other than that, nice
clean up!

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/