linux-kernel - Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185992994.2636.142.camel@imap.mvista.com>
Date:	Wed, 01 Aug 2007 11:29:54 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Gregory Haskins <ghaskins@...ell.com>,
	linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RT: Add priority-queuing and priority-inheritance to
	workqueue infrastructure

On Wed, 2007-08-01 at 22:12 +0400, Oleg Nesterov wrote:

> And I personally think it is not very useful, even if it was correct.
> You can create your own workqueue and change the priority of cwq->thread.

This change is more dynamic than than just setting a single priority ..
There was some other work going on around this, so it's not totally
clear what the benefits are ..

> > > @@ -168,7 +171,7 @@ int fastcall queue_work(struct workqueue
> > >  	int ret = 0, cpu = raw_smp_processor_id();
> > >  
> > >  	if (!test_and_set_bit(WORK_STRUCT_PENDING, work_data_bits(work))) {
> > > -		BUG_ON(!list_empty(&work->entry));
> > > +		BUG_ON(!plist_node_empty(&work->entry));
> > >  		__queue_work(wq_per_cpu(wq, cpu), work);
> > >  		ret = 1;
> 
> Side note, looks like you use some strange kernel. This raw_smp_processor_id()
> above is wrong.

As the topic suggests , it's a Real Time kernel .. I can give you a link
where to download it if you want.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/