linux-kernel - [PATCH] qla2xxx: allocate enough space for the full PCI descriptor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070801221340.GA4370@plap.qlogic.org>
Date:	Wed, 1 Aug 2007 15:13:40 -0700
From:	Andrew Vasquez <andrew.vasquez@...gic.com>
To:	James Bottomley <james.bottomley@...eleye.com>
Cc:	Ulrich Windl <ulrich.windl@...uni-regensburg.de>,
	Andrew Patterson <andrew.patterson@...com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] qla2xxx: allocate enough space for the full PCI descriptor.

Signed-off-by: Andrew Vasquez <andrew.vasquez@...gic.com>
---

	On Thu, 26 Jul 2007, Andrew Vasquez wrote:

	> On Thu, 26 Jul 2007, Andrew Patterson wrote:
	> 
	> > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
	> > > Hi,
	> > > 
	> > > <6>QLogic Fibre Channel HBA Driver
	> > > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
	> > > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
	> > > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
	> > > [...]
	> > > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
	> > > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
	> > > <6>scsi0 : qla2xxx
	> > > <6>qla2xxx 0000:0f:01.0:
	> > > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
	> > > <4>  QLogic HP AB378-60001 -
	> > > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
	> > > fw=4.00.26 [IP]
	> 
	> The 33/66/100/133 values refer to the bus-clock speed at which the
	> card is operating.  As is seen here (although a bit truncated --
	> separate issue, I'll try to see if I can reproduce this on one of my
	> HPQ rigs),

	Ok, so what's happening here is the buffer passed in (pci_info)
	does not have bytes allocated (off by 3).

	James, please apply...

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 93c0c7e..acca898 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1564,7 +1564,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct Scsi_Host *host;
 	scsi_qla_host_t *ha;
 	unsigned long	flags = 0;
-	char pci_info[20];
+	char pci_info[30];
 	char fw_str[30];
 	struct scsi_host_template *sht;
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/