linux-kernel - Re: [2.6 patch] dvb_frontend_ioctl(): fix check-after-use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a297b360707312052l14adb72el8ee59c74b7757605@mail.gmail.com>
Date:	Wed, 1 Aug 2007 07:52:29 +0400
From:	"Manu Abraham" <abraham.manu@...il.com>
To:	"Adrian Bunk" <bunk@...sta.de>
Cc:	v4l-dvb-maintainer@...uxtv.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] dvb_frontend_ioctl(): fix check-after-use

On 7/31/07, Adrian Bunk <bunk@...sta.de> wrote:
> The Coverity checker spotted that we have already oops'ed if "fe" was NULL.
>
> Since "fe" being NULL seems impossible at this point this patch removes
> the NULL check.
>
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/media/dvb/dvb-core/dvb_frontend.c.old  2007-07-29 21:41:56.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/media/dvb/dvb-core/dvb_frontend.c      2007-07-29 21:42:16.000000000 +0200
> @@ -706,11 +706,11 @@ static int dvb_frontend_ioctl(struct ino
>         struct dvb_frontend_private *fepriv = fe->frontend_priv;
>         int err = -EOPNOTSUPP;
>
>         dprintk ("%s\n", __FUNCTION__);
>
> -       if (!fe || fepriv->exit)
> +       if (fepriv->exit)
>                 return -ENODEV;
>
>         if ((file->f_flags & O_ACCMODE) == O_RDONLY &&
>             (_IOC_DIR(cmd) != _IOC_READ || cmd == FE_GET_EVENT ||
>              cmd == FE_DISEQC_RECV_SLAVE_REPLY))
>
> -

Acked-by: Manu Abraham <manu@...uxtv.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/