linux-kernel - Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B1DABA.3090800@zytor.com>
Date:	Thu, 02 Aug 2007 09:23:06 -0400
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Antonino A. Daplas" <adaplas@...il.com>
CC:	Daniel Drake <dsd@...too.org>,
	Zwane Mwaikambo <zwane@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Beulich <jbeulich@...ell.com>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...e.de>
Subject: Re: [PATCH] retrieve VBE EDID/DDC info independent of used video
 mode

Antonino A. Daplas wrote:

>  
> How about this patch?
> 
> Tony
> ---
> 
> Subject: video setup: Fix VBE DDC reading
> 
> Add memory operand constraint and write-only modifier to the inline
> assembly to effect the writing of the EDID block to boot_params.edid_info.
> 
> Signed-off-by: Antonino Daplas <adaplas@...il.com>

OK, now I feel dumb.  You're absolutely right; without that constraint, 
the entire EDID function after the memset is eliminated by gcc as being 
dead code.

Will queue the patch.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/