linux-kernel - Re: [PATCH 06/68] 0 -> NULL, for arch/frv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200708021058.47811.rgetz@blackfin.uclinux.org>
Date:	Thu, 2 Aug 2007 10:58:47 -0400
From:	Robin Getz <rgetz@...ckfin.uclinux.org>
To:	"Richard Knutsson" <ricknu-0@...dent.ltu.se>
Cc:	"Mike Frysinger" <vapier.adi@...il.com>,
	"Yoann Padioleau" <padator@...adoo.fr>,
	"David Howells" <dhowells@...hat.com>,
	kernel-janitors@...r.kernel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/68] 0 -> NULL, for arch/frv

On Wed 1 Aug 2007 06:38, Richard Knutsson pondered:
> If I understood Robin correctly, he suggested that checkpatch.pl would 
> tell to convert "x == NULL" to "!x", if that would be the preferred way.

I guess I was asking - _if_ this is really important - lets pick a 
preferred way, and try to use the existing infrastructure (sparce 
or checkpatch.pl) to try to enforce it.

If it is just pedantic - let it go. There are lots of ways to do the 
same thing, one is not necessarily more correct. (but in this case - 
I see the point, and agree).

> BTW, too bad checkpatch.pl does not know the types, since it otherwise 
> could check for the "x [=!]= 0"-thing.

Then let's ask people to use sparse on anything in their diffstat.
(or at least recommend it).

Sparse isn't mentioned in Documentation/SubmittingPatches yet. (if
it is a suggestion)

Even something completely stupid like:

diff -uprN old new | diffstat -p 0 | grep -v changed | awk '{print $1}' | sed 's/\.c/\.o/' | xargs make C=2

worked for me.

-Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/