linux-kernel - Re: [PATCH][Fix] Hibernation: Do not try to mark invalid PFNs as nosave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070802175518.GA22547@elf.ucw.cz>
Date:	Thu, 2 Aug 2007 19:55:18 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH][Fix] Hibernation: Do not try to mark invalid PFNs as nosave

Hi!

> [Please consider as 2.6.23 material.]
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> On some systems some PFNs reported by the early initialization code as 'nosave'
> may be invalid.  If we try to set the corresponding bits in the hibernation
> bitmap, BUG_ON() in memory_bm_find_bit() will be triggered and the system
> won't be able to boot  (cf. https://bugzilla.novell.com/show_bug.cgi?id=296242).
> 
> Prevent this from happening by verifying if the 'nosave' PFNs are valid in
> mark_nosave_pages().
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

ACK.

> @@ -709,7 +709,8 @@ static void mark_nosave_pages(struct mem
>  				region->end_pfn << PAGE_SHIFT);
>  
>  		for (pfn = region->start_pfn; pfn < region->end_pfn; pfn++)
> -			memory_bm_set_bit(bm, pfn);
> +			if (pfn_valid(pfn))
> +				memory_bm_set_bit(bm, pfn);
>  	}
>  }
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/