linux-kernel - Re: [PATCH] drivers/char/sonypi.c: fix ids member of struct acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070802064034.GF25969@inferi.kami.home>
Date:	Thu, 2 Aug 2007 15:40:34 +0900
From:	Mattia Dongili <malattia@...ux.it>
To:	Eugene Teo <eugeneteo@...nel.sg>, Len Brown <lenb@...nel.org>,
	Thomas Renninger <trenn@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/char/sonypi.c: fix ids member of struct
	acpi_driver

On Wed, Aug 01, 2007 at 05:15:34PM +0800, Eugene Teo wrote:
> ids member of struct acpi_driver is of type struct acpi_device_id, not a
> character array.
> 
> Signed-off-by: Eugene Teo <eugeneteo@...nel.sg>
> ---
>  drivers/char/sonypi.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
> index 73037a4..ac0aeb0 100644
> --- a/drivers/char/sonypi.c
> +++ b/drivers/char/sonypi.c
> @@ -1147,10 +1147,16 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
>  	return 0;
>  }
>  
> +const static struct acpi_device_id sonypi_device_ids[] = {
> +	{"SNY6001", 0},
> +	{"", 0},
> +};
> +MODULE_DEVICE_TABLE(acpi, sonypi_device_ids);

how does it behave with the already existing id in sony-laptop?
I'd rather avoid the MODULE_DEVICE_TABLE for sonypi allowing sony-laptop
to take over automagically.

-- 
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/