linux-kernel - Re: [PATCH] mtdsuper: licensce = GPL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0708021309430.8258@enigma.security.iitk.ac.in>
Date:	Thu, 2 Aug 2007 13:44:37 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	Rafał Bilski <rafalbilski@...eria.pl>
cc:	trivial@...nel.org, David Woodhouse <dwmw2@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtdsuper: licensce = GPL

Hi,


On Thu, 2 Aug 2007, Rafał Bilski wrote:

> > > block2mtd: version $Revision: 1.30 $
> > > block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536]
> > > mtdsuper: module license 'unspecified' taints kernel.
> > > mtdsuper: Unknown symbol get_mtd_device
> > > mtdsuper: Unknown symbol put_mtd_device
> > > jffs2: Unknown symbol get_sb_mtd
> > > jffs2: Unknown symbol kill_mtd_super
> > 
> > That's weird. I'm wondering how did you manage to build mtdsuper as a
> > separate module in the first place? It always gets linked with mtdcore
> > (which has all the necessary module decoration stuff) into the "mtd"
> > module itself, at least that;s what the Makefile says ...
> 
> I don't know. Just "make oldconfig" (~2.6.21) and "make". I have mtdcore as a
> separate module too. That's weird: /Makefile claims that it is 2.6.22.1, but
> looking at the sources I see changes present in 2.6.23-rc1. I have downloaded
> 2.6.22.1 in the first place and patched it with -rc1 and -rc1-git3 patch. 

You should apply -rcN or -gitX patches on the previous Linus' kernel
(2.6.x) and not the 2.6.x.y "-stable" ones -- those are a "parallel" tree.

> # ls *.ko
> ftl.ko  mtd_blkdevs.ko  mtdblock.ko  mtdchar.ko  mtdcore.ko  mtdpart.ko
> mtdsuper.ko

Hmm, you've got mtdpart build separately as well. Could you redo as per
what I suggested above (take 2.6.22, apply -rc1, then -rc1-git3) and then
rebuild after "make oldconfig" ... and let us know if you still end up
with these modules? Could also be a make/toolchain issue at your end,
for all I know.


Satyam