linux-kernel - Re: 2.6.23-rc1-mm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070803093830.39852a01.akpm@linux-foundation.org>
Date:	Fri, 3 Aug 2007 09:38:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marc Dietrich <Marc.Dietrich@...physik.uni-giessen.de>
Cc:	linux-kernel@...r.kernel.org, nfs@...ts.sourceforge.net,
	Neil Brown <neilb@...e.de>, Oleg Nesterov <oleg@...sign.ru>,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: 2.6.23-rc1-mm2

On Fri, 3 Aug 2007 13:00:46 +0200 Marc Dietrich <Marc.Dietrich@...physik.uni-giessen.de> wrote:

> 
> Hi,
> 
> Am Wednesday 01 August 2007 08:09 schrieb Andrew Morton:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.
> >6.23-rc1-mm2/
> >
> >
> > - the git-block tree remains dropped due to disageement with the Vaio
> >
> > - git-e1000new was withdrawn by the authors
> >
> > - git-wireless is back.  It is still a >3MB diff, and appears to compile.
> >
> > - Is anyone testing the kgdb code in here?
> 
> I still get some nfs related locking bug.
> 
> I applied 
> 
> linux-2.6.23-001-fix_rpciod_down_race.dif
> linux-2.6.23-003-fix_locking_regression.dif
> linux-2.6.23-004-fix_stateid_regression.dif
> 
> =============================================
> [ INFO: possible recursive locking detected ]
> 2.6.23-rc1-mm2 #3
> ---------------------------------------------
> events/0/5 is trying to acquire lock:
>  (events){--..}, at: [<c012ed90>] flush_workqueue+0x0/0x70
> 
> but task is already holding lock:
>  (events){--..}, at: [<c012e5c4>] run_workqueue+0xd4/0x1e0
> 
> other info that might help us debug this:
> 2 locks held by events/0/5:
>  #0:  (events){--..}, at: [<c012e5c4>] run_workqueue+0xd4/0x1e0
>  #1:  ((nfs_automount_task).work){--..}, at: [<c012e5c4>] 
> run_workqueue+0xd4/0x1e0
> 
> stack backtrace:
>  [<c0104fda>] show_trace_log_lvl+0x1a/0x30
>  [<c0105c02>] show_trace+0x12/0x20
>  [<c0105d15>] dump_stack+0x15/0x20
>  [<c013ee42>] __lock_acquire+0xc22/0x1030
>  [<c013f2b1>] lock_acquire+0x61/0x80
>  [<c012edd9>] flush_workqueue+0x49/0x70
>  [<c012ee0d>] flush_scheduled_work+0xd/0x10
>  [<dcf55c0c>] nfs_release_automount_timer+0x2c/0x30 [nfs]
>  [<dcf45d8e>] nfs_free_server+0x9e/0xd0 [nfs]
>  [<dcf4e626>] nfs_kill_super+0x16/0x20 [nfs]
>  [<c017b38d>] deactivate_super+0x7d/0xa0
>  [<c018f94b>] mntput_no_expire+0x4b/0x80
>  [<c018fd94>] expire_mount_list+0xe4/0x140
>  [<c0191219>] mark_mounts_for_expiry+0x99/0xb0
>  [<dcf55d1d>] nfs_expire_automounts+0xd/0x40 [nfs]
>  [<c012e61b>] run_workqueue+0x12b/0x1e0
>  [<c012f05b>] worker_thread+0x9b/0x100
>  [<c0131c72>] kthread+0x42/0x70
>  [<c0104c0f>] kernel_thread_helper+0x7/0x18
>  =======================
> 

There is new debugging stuff in -mm: deadlockable usage of workqueue
primitives will now trigger lockdep warnings.  See

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm2/broken-out/workqueue-debug-flushing-deadlocks-with-lockdep.patch
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm2/broken-out/workqueue-debug-work-related-deadlocks-with-lockdep.patch

I am suspecting that running flush_scheduled_work() from within run_workqueue()
isn't good.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/