linux-kernel - Re: [-mm patch] DMA engine kconfig improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c3a7c20708031915y1fee8c62i9da0f42cddbb44dd@mail.gmail.com>
Date:	Fri, 3 Aug 2007 19:15:31 -0700
From:	"Dan Williams" <dan.j.williams@...el.com>
To:	"Adrian Bunk" <bunk@...sta.de>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Shannon Nelson" <shannon.nelson@...el.com>,
	linux-kernel@...r.kernel.org, "Wolfgang Denk" <wd@...x.de>
Subject: Re: [-mm patch] DMA engine kconfig improvements

On 7/25/07, Adrian Bunk <bunk@...sta.de> wrote:
> On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc6-mm1:
> >...
> > +dma-arch-fix.patch
> >
> >  Fix git-dma.patch
> >...
>
> This results in an ARM-only driver in an X86-only menu...
>
> What about the patch below instead that also improves a few other things?
I like it, just a few nits:

> -menu "DMA Engine support"
> -       depends on HAS_DMA
> +menuconfig DMADEVICES
> +       bool "DMA Engine support"
> +       depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> +       help
> +         Intel(R) DMA engines
> +
Perhaps we should go ahead and define ARCH_HAS_DMA_OFFLOAD and have
DMADEVICES depend on that option.  A ppc32 driver is in the works:
http://marc.info/?l=linux-raid&m=117400143317440&w=2

> +if DMADEVICES
> +
> +comment "DMA Devices"
> +
> +config INTEL_IOATDMA
> +       tristate "Intel I/OAT DMA support"
> +       depends on PCI && X86
> +       select DMA_ENGINE
> +       select DCA
> +       help
> +         Enable support for the Intel(R) I/OAT DMA engine present
> +         in recent Intel Xeon CPUs.
> +
> +         Say yes if you have such a CPU.
It is actually in recent chipsets, not the CPU, but yes the user
should have more help making this decision.

Regards,
Dan (for Shannon while he is on vacation)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/