[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <200708042031.54363.jesper.juhl@gmail.com>
Date: Sat, 4 Aug 2007 20:31:54 +0200
From: Jesper Juhl <jesper.juhl@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
isdn4linux@...tserv.isdn4linux.de, Carsten Paeth <calle@...le.de>,
Kai Germaschewski <kai@...maschewski.name>,
Karsten Keil <kkeil@...e.de>,
Kai Germaschewski <kai.germaschewski@....de>,
Jesper Juhl <jesper.juhl@...il.com>
Subject: [PATCH][RESEND][ISDN] Guard against a potential NULL pointer dereference in old_capi_manufacturer()
(first send: Monday 25 June 2007, resending due to no response)
(resending again on August 8'th, 2007)
In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call
to get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then
we'll be dereferencing a NULL pointer in the very next line.
(Found by Coverity checker as bug #402)
Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---
drivers/isdn/capi/kcapi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c
index 3ed34f7..3f9e962 100644
--- a/drivers/isdn/capi/kcapi.c
+++ b/drivers/isdn/capi/kcapi.c
@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void
__user *data)
return -EFAULT;
}
card = get_capi_ctr_by_nr(ldef.contr);
+ if (!card)
+ return -EINVAL;
card = capi_ctr_get(card);
if (!card)
return -ESRCH;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists