lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Aug 2007 01:40:49 +0200 From: Andi Kleen <ak@...e.de> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Chuck Ebbert <cebbert@...hat.com>, Muli Ben-Yehuda <muli@...ibm.com>, linux-kernel <linux-kernel@...r.kernel.org>, riku.seppala@...p.net, Andy Whitcroft <apw@...dowen.org> Subject: Re: Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask() On Saturday 04 August 2007 18:32:22 Andrew Morton wrote: > On Sat, 4 Aug 2007 11:30:41 +0200 Andi Kleen <ak@...e.de> wrote: > > > On Saturday 04 August 2007 00:50, Andrew Morton wrote: > > > On Fri, 03 Aug 2007 18:10:03 -0400 > > > > > > Chuck Ebbert <cebbert@...hat.com> wrote: > > > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250859 > > > > > > > > at line 74: > > > > > > > > muli@...29: > > > > muli@...29: sd = bus->sysdata; > > > > muli@...29: sd->node = node; <===== > > > > > > > > bus->sysdata is NULL. > > > > > > > > Last changed by this hunk of > > > > "x86-64: introduce struct pci_sysdata to facilitate sharing of > > > > ->sysdata": > > > > Hmm, will double check. Perhaps Muli's conversion was incomplete. > > hm. > > > > > @@ -67,7 +69,9 @@ fill_mp_bus_to_cpumask(void) > > > > continue; > > > > if (!node_online(node)) > > > > node = 0; > > > > - bus->sysdata = (void *)node; > > > > + > > > > + sd = bus->sysdata; > > > > + sd->node = node; > > > > } > > > > } > > > > } > > > > > > Andy keeps trotting out a patch which will probably fix this, > > > > What patch do you mean? I don't have anything sysdata related > > left over. > > > > "pci device ensure sysdata initialised", now at version 4. Oh what a mess. I think I'll ask Linus to revert the sysdata patch instead. Clearly the stuff is half-baked -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists