linux-kernel - Re: [PATCH] au88x0: mem leak fix in snd_vortex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B44B2B.7050609@gmail.com>
Date:	Sat, 04 Aug 2007 11:47:23 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	Jesper Juhl <jesper.juhl@...il.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Manuel Jander <mjander@...edded.cl>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] au88x0: mem leak fix in snd_vortex_create()

On 08/04/2007 02:09 AM, Jesper Juhl wrote:

> In sound/pci/au88x0/au88x0.c::snd_vortex_create() : 
> The Coverity checker found that if we allocate storage for 'chip' 
> but then leave via the  regions_out:  label, then we end up leaking 
> the storage allocated for 'chip'.
> I believe simply freeing 'chip' before the "return err;" line is 
> all we need to fix this, but please double-check me :)
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> ---
> 
> diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
> index 5ec1b6f..f70286a 100644
> --- a/sound/pci/au88x0/au88x0.c
> +++ b/sound/pci/au88x0/au88x0.c
> @@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)
>  	pci_disable_device(chip->pci_dev);
>  	//FIXME: this not the right place to unregister the gameport
>  	vortex_gameport_unregister(chip);
> +	kfree(chip);
>  	return err;
>  }

ACK.

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/