linux-kernel - Re: [PATCH] sonypi: Fix initialization warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B62CFE.2010404@student.ltu.se>
Date:	Sun, 05 Aug 2007 22:03:10 +0200
From:	Richard Knutsson <ricknu-0@...dent.ltu.se>
To:	trenn@...e.de
CC:	Ben Collins <bcollins@...ntu.com>,
	"Brown, Len" <len.brown@...el.com>, linux-acpi@...r.kernel.org,
	Stelian Pop <stelian@...ies.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sonypi: Fix initialization warning

Thomas Renninger wrote:
> On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote:
>   
>> Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
>> ---
>> Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)):
>> drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type
>>
>>
>> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
>> index 73037a4..2dcd519 100644
>> --- a/drivers/char/sonypi.c
>> +++ b/drivers/char/sonypi.c
>> @@ -1147,10 +1147,15 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
>>  	return 0;
>>  }
>>  
>> +static const struct acpi_device_id sonypi_acpi_driver_ids[] = {
>> +        {ACPI_PROCESSOR_HID, 0},
>>     
> This is wrong. You need to take the HID the driver should match for, in
> this case: {"SNY6001", 0 },
>   
Oh bugger, a cut 'n' paste error...
Thanks for reviewing it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/