linux-kernel - Re: [PATCH] [34/58] x86_64: ia32entry adjustments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Aug 2007 11:43:45 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Jeff Garzik" <jeff@...zik.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Andi Kleen" <ak@...e.de>, <linux-kernel@...r.kernel.org>,
	<patches@...-64.org>
Subject: Re: [PATCH] [34/58] x86_64: ia32entry adjustments

>>> Jeff Garzik <jeff@...zik.org> 19.07.07 16:46 >>>
>Andi Kleen wrote:
>> From: "Jan Beulich" <jbeulich@...ell.com>
>> Consolidate the three 32-bit system call entry points so that they all
>> treat registers in similar ways.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>> Signed-off-by: Andi Kleen <ak@...e.de>
>> 
>>  arch/x86_64/ia32/ia32entry.S |    5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> Index: linux/arch/x86_64/ia32/ia32entry.S
>> ===================================================================
>> --- linux.orig/arch/x86_64/ia32/ia32entry.S
>> +++ linux/arch/x86_64/ia32/ia32entry.S
>> @@ -104,7 +104,7 @@ ENTRY(ia32_sysenter_target)
>>  	pushq	%rax
>>  	CFI_ADJUST_CFA_OFFSET 8
>>  	cld
>> -	SAVE_ARGS 0,0,0
>> +	SAVE_ARGS 0,0,1
>>   	/* no need to do an access_ok check here because rbp has been
>>   	   32bit zero extended */ 
>>  1:	movl	(%rbp),%r9d
>> @@ -294,7 +294,7 @@ ia32_badarg:
>>   */ 				
>>  
>>  ENTRY(ia32_syscall)
>> -	CFI_STARTPROC	simple
>> +	CFI_STARTPROC32	simple
>>  	CFI_SIGNAL_FRAME
>>  	CFI_DEF_CFA	rsp,SS+8-RIP
>>  	/*CFI_REL_OFFSET	ss,SS-RIP*/
>> @@ -330,6 +330,7 @@ ia32_sysret:
>>  
>>  ia32_tracesys:			 
>>  	SAVE_REST
>> +	CLEAR_RREGS
>>  	movq $-ENOSYS,RAX(%rsp)	/* really needed? */
>>  	movq %rsp,%rdi        /* &pt_regs -> arg1 */
>>  	call syscall_trace_enter
>
>More comments and/or a less vague patch description would be nice.
>
>What registers?  What behavior is being made common?  Why?

I think the description says this quite well - which registers are being saved/
cleared is being made consistent (not common).

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/