[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <18102.33136.963233.867247@gargle.gargle.HOWL>
Date: Sun, 5 Aug 2007 21:03:28 -0500
From: boutcher@...umn.edu (Dave Boutcher)
To: Matt Mackall <mpm@...enic.com>
CC: linux-kernel@...r.kernel.org
Subject: [PATCH] Fix /proc/pid/pagemap end address calculation
When dumping vma information the pagemap_read routine calculates
the minimum of what the user asks for and the end of the vma.
Unfortunately the code uses vma->vm_start rather than vma->vm_end
which can result in the end address being before the start, and
a nasty never-ending loop in the kernel.
Diffed against 2.6.23-rc1-mm2
Signed-off-by: Dave Boutcher <boutcher@...umn.edu>
---
fs/proc/task_mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index b2baeab..b12740c 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -671,7 +671,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
ret = -EIO;
goto out_mm;
}
- vend = min(vma->vm_start - 1, end - 1) + 1;
+ vend = min(vma->vm_end - 1, end - 1) + 1;
ret = pagemap_fill(&pm, vend);
if (ret || !pm.count)
break;
--
1.4.4.2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists