linux-kernel - Re: Kernel Bug in 2.4.35 when compiled gcc>=4.2.0 and -march=c3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Aug 2007 10:39:28 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Willy Tarreau <w@....eu>
CC:	Segher Boessenkool <segher@...nel.crashing.org>,
	Axel Reinhold <axel@...akout.de>, linux-kernel@...r.kernel.org
Subject: Re: Kernel Bug in 2.4.35 when compiled gcc>=4.2.0 and -march=c3

Willy Tarreau wrote:
> 
> Just to enlighten me on the subject, could you please explain me
> what is wrong in the code ? Granted I found it awful, but even on
> the GCC-4.2 page where -fno-toplevel-reorder is explained, it is
> said that asm statements can be instantiated between functions
> blocks, which is exactly what is used here.
> 

A stray semicolon:

__attribute__((regparm(0))) void call_do_IRQ(void); __asm__(...

... is actually a prototype followed by a top-level asm statement
(because of the semicolon), *not* a function with a single-statement
body (which is itself uglier than hell, use braces please...)

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/