[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070806223019.GA19389@suse.de>
Date: Tue, 7 Aug 2007 00:30:19 +0200
From: Olaf Hering <olh@...e.de>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Stefan Richter <stefanr@...6.in-berlin.de>,
Robert Hancock <hancockr@...w.ca>, linuxppc-dev@...abs.org,
stable@...nel.org, linux-kernel@...r.kernel.org,
Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH] powerpc: Fix initialization and usage of dma_mask
On Tue, Aug 07, Benjamin Herrenschmidt wrote:
> powerpc has a couple of bugs in the usage of dma_masks that tend to
> break when drivers explicitely try to set a 32 bits mask for example.
>
> First the code that generates the pci devices from the OF device-tree
> doesn't initialize the mask properly, then our implementation of
> set_dma_mask() was trying to validate the -previous- mask value, not the
> one passed in as an argument.
>
> This patch should fix these.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
>
> Does this fix the problem you've noticed ?
This patch fixes it. Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists