linux-kernel - Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070807151945.GA4864@sergelap.austin.ibm.com>
Date:	Tue, 7 Aug 2007 10:19:45 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	James Morris <jmorris@...ei.org>
Cc:	"Serge E. Hallyn" <serue@...ibm.com>,
	Andrew Morgan <morgan@...nel.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Andrew Morgan <agm@...gle.com>, casey@...aufler-ca.com,
	Andrew Morton <akpm@...gle.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	KaiGai Kohei <kaigai@...gai.gr.jp>,
	linux-security-module@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

Quoting James Morris (jmorris@...ei.org):
> On Tue, 7 Aug 2007, Serge E. Hallyn wrote:
> 
> > Shall I resend without the LSM_NEED_LOCK, or do you still want a more
> > fundamental change?
> 
> 
> Removing the needlock is enough, the rest was just a query/suggestion.

Ok - I'll explictly lock the i_mutex in
fs/splice.c:generic_file_splice_write().  The ugliness there is that
the mutex will always be taken - even if there is no xattr to be
removed or even if CONFIG_SECURITY=n.

I guess I'll do some perf runs and see what kind of impact that has.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/