linux-kernel - Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708072336030.26397@fbirervta.pbzchgretzou.qr>
Date:	Tue, 7 Aug 2007 23:37:06 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Greg KH <gregkh@...e.de>
cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, bunk@...sta.de,
	Ingo Molnar <mingo@...e.hu>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.


On Aug 7 2007 13:43, Greg KH wrote:
>
>added this 64-bit bug:
>
>        ....
>	unsigned int flags;
>
> 	spin_lock_irqsave(&task->lock, flags);
>        ....
>
>irq 'flags' must be unsigned long, not unsigned int. The -rt tree has
>strict checks about this on 64-bit so this triggered a build failure.

Since the check is a compile-time one, would not it be good to add
it to the regular linux tree too?


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/