linux-kernel - Re: Error message from device_rename in drivers/base/core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Aug 2007 11:33:59 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	David Miller <davem@...emloft.net>
Cc:	Larry.Finger@...inger.net, linux-kernel@...r.kernel.org
Subject: Re: Error message from device_rename in drivers/base/core.c

On Tue, 07 Aug 2007 21:37:24 -0700 (PDT),
David Miller <davem@...emloft.net> wrote:

> From: Larry Finger <Larry.Finger@...inger.net>
> Date: Tue, 07 Aug 2007 23:17:23 -0500
> 
> > I am getting the following error message from drivers/base/core.c:
> > 
> > net eth1: device_rename: sysfs_create_symlink failed (-17)
> > 
> > Upon investigation, the call generating the error is renaming 'eth1' to 'eth1'. The following patch 
> > suppresses the error.
> 
> I think this check belongs in udev not in the kernel.  Thankfully
> this message at least tells us it is happening, please don't
> remove it.

Hm, device_rename() could alternatively just return success if
dev->bus_id and new_name are the same.

> 
> I'm pretty sure it's UDEV doing this, and it should not try to rename
> a netdevice to what it already is named.

But it shouldn't cause an error either :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/